Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Halfway - Menu Improvements + Providing Help to User #327

Merged
merged 4 commits into from
Oct 25, 2022

Conversation

CharSong24
Copy link
Collaborator

It is an unfinished version. With talking to the group leader, we decide to use a web page to replace the Pop-up window dialog. So far, the web page hasn't set up yet, I just put Github legup link here, waiting to have a real dialog web page in the future.

Description

Closes #(issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [yes] New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my code
  • [yes] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

It is an unfinished version. With talking to the group leader, we decide to use a web page to replace the Pop-up window dialog. So far, the web page hasn't set up yet, I just put Github legup link here, waiting to have a real dialog web page in the future.
@Chase-Grajeda
Copy link
Collaborator

Copy link
Collaborator

@Chase-Grajeda Chase-Grajeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed tests, link and new menu item work as expected

@Chase-Grajeda Chase-Grajeda merged commit 3c61107 into Bram-Hub:dev Oct 25, 2022
@Chase-Grajeda
Copy link
Collaborator

Chase-Grajeda commented Oct 25, 2022

Closes #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants