Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Explorer Changes #318

Merged
merged 7 commits into from
Oct 21, 2022
Merged

File Explorer Changes #318

merged 7 commits into from
Oct 21, 2022

Conversation

anthonyfabius
Copy link
Collaborator

Description

Closes #(310)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Multiple game files have been opened with the new explorer.
  • Opening a different file while in a game.
  • The alteration of user preferences to see if they are reflected on the explorer

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

anthonyfabius and others added 6 commits October 3, 2022 19:21
Just added extended the enum of  Masyu data types and added to the change cell function so a future developer can see how they should implement cell data changes.
Solve Puzzle Menu Button: Got rid of custom java swing file explorer and replaced it with windows file explorer.

Edit Puzzle Menu Button: Adjusted to show user preferred file from preferences.
Checkstyle gave me some erros because of my curly brace placement
Now when a file cannot be read a new file explorer is opened until a valid one is selected
I forgot to commit a line
@anthonyfabius
Copy link
Collaborator Author

I committed some more code that reopens the file explorer if the first file selected is faulty. The JPanel Error message still shows up but now when you click "Ok" to close it a new file explorer opens so that the user can open up a new (hopefully valid) file.

Copy link
Collaborator

@Chase-Grajeda Chase-Grajeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes test cases, ready for merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants