Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #315

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Dev #315

merged 2 commits into from
Oct 21, 2022

Conversation

BoZhiDeng
Copy link
Collaborator

@BoZhiDeng BoZhiDeng commented Oct 7, 2022

Description

Fix bug #255 by applying "checkProof()" from the ProofEditorPanel as the action listener.
The last update was git from the wrong branch; it should work on the dev branch now.

Closes #(255 )

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Fix Bram-Hub#255 by apply the action listener of "toolBarButtons[ToolbarName.CHECK_ALL.ordinal()]" in ProofEditorPanel
Copy link
Collaborator

@Chase-Grajeda Chase-Grajeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Batch grader button now calls proper function, but fails to execute. Will create separate issue

@Chase-Grajeda Chase-Grajeda merged commit 0f4b8d9 into Bram-Hub:dev Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants