Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light Up Satisfy Case Rule Bug #45

Closed
charlestian23 opened this issue Oct 7, 2021 · 2 comments
Closed

Light Up Satisfy Case Rule Bug #45

charlestian23 opened this issue Oct 7, 2021 · 2 comments
Assignees
Labels
bug Something isn't working light up

Comments

@charlestian23
Copy link
Collaborator

charlestian23 commented Oct 7, 2021

image

The last step in the given proof is incorrectly marked as valid. However, if the lightbulb to the right of the top middle 2 in the second-to-last step is removed, then the last step is correctly marked as invalid.

Light Up - Case Rule (accepts only branch when there are more).zip

@charlestian23 charlestian23 added bug Something isn't working light up labels Oct 7, 2021
@charlestian23
Copy link
Collaborator Author

A possible solution to this is just to disable using case rules as justification for the arrows. For example, if a user tries to click on a case rule to justify an arrow, we can just have an error message pop up.

@Bram28
Copy link
Member

Bram28 commented Oct 14, 2021

@charlestian23 But that is of course just a band-aid .. there is something inherently wrong with the logic here: it makes no sense that the placement of that bulb to the right of the top middle 2 in the second-to-last step would effect the validity of the last step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working light up
Projects
None yet
Development

No branches or pull requests

3 participants