Skip to content

Commit

Permalink
Issue 513 (#517)
Browse files Browse the repository at this point in the history
* Revert "Update PuzzleEditorPanel.java"

* Update SkyscrapersBoard.java

* input and updated descriptions for @return and @throws

* Update Puzzle.java

* Update ScrollView.java

* Update WrapLayout.java

* Update NumberTile.java

* Update DropShadowBorder.java

* Erased irrelevant code

* Update Puzzle.java

---------

Co-authored-by: Charles Tian <[email protected]>
Co-authored-by: Ivan Ho <[email protected]>
  • Loading branch information
3 people authored Apr 4, 2023
1 parent aca1ea0 commit a735dc1
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 20 deletions.
2 changes: 1 addition & 1 deletion src/main/java/edu/rpi/legup/app/Config.java
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public List<String> getFileCreationEnabledPuzzles() {
* convertClassNameToDisplayName("Nurikabe") will return "Nurikabe"
*
* @param className the name of the class
* @return
* @return displayName the name of the puzzle
*/
public static String convertClassNameToDisplayName(String className) {
String displayName = "";
Expand Down
10 changes: 3 additions & 7 deletions src/main/java/edu/rpi/legup/model/Puzzle.java
Original file line number Diff line number Diff line change
Expand Up @@ -249,9 +249,7 @@ public boolean isPuzzleComplete() {
* Imports the board using the file stream
*
* @param fileName
* @throws IOException
* @throws ParserConfigurationException
* @throws SAXException
* @throws InvalidFileFormatException
*/
public void importPuzzle(String fileName) throws InvalidFileFormatException {
try {
Expand All @@ -267,9 +265,7 @@ public void importPuzzle(String fileName) throws InvalidFileFormatException {
* Imports the board using the file stream
*
* @param inputStream
* @throws IOException
* @throws ParserConfigurationException
* @throws SAXException
* @throws InvalidFileFormatException
*/
public void importPuzzle(InputStream inputStream) throws InvalidFileFormatException {
Document document;
Expand Down Expand Up @@ -647,4 +643,4 @@ public void notifyTreeListeners(Consumer<? super ITreeListener> algorithm) {
public boolean checkValidity() {
return true;
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ public int getTileNumber() {

/**
* @param num Amount to set tile object to.
* @return none
*/
public void setTileNumber(int num) {
object_num = num;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,28 +51,28 @@ public ArrayList<SkyscrapersLine> getLines() {
}

/**
* Returns a list of the eastern clues ordered from loc.y = 0->max
*/
* Returns a list of the eastern clues ordered from loc.y = 0 to max
*/
public ArrayList<SkyscrapersClue> getEastClues() {
return eastClues;
}

/**
* Returns a list of the southern clues ordered from loc.x = 0->max
* Returns a list of the southern clues ordered from loc.x = 0 to max
*/
public ArrayList<SkyscrapersClue> getSouthClues() {
return southClues;
}

/**
* Returns a list of the western clues ordered from loc.y = 0->max
* Returns a list of the western clues ordered from loc.y = 0 to max
*/
public ArrayList<SkyscrapersClue> getWestClues() {
return westClues;
}

/**
* Returns a list of the northern clues ordered from loc.x = 0->max
* Returns a list of the northern clues ordered from loc.x = 0 to max
*/
public ArrayList<SkyscrapersClue> getNorthClues() {
return northClues;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ public int getTileNumber() {

/**
* @param num Amount to set tile object to.
* @return none
*/
public void setTileNumber(int num) {
object_num = num;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/edu/rpi/legup/ui/ScrollView.java
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public void updatePosition(Point point, double magnification) {
/**
* Zooms in or out on a position within the dynamicView
*
* @param n level of zoom - n < 0 is zoom in, n > 0 is zoom out
* @param n level of zoom - n less than 0 is zoom in, n greater than 0 is zoom out
* @param point position to zoom in on
*/
public void zoom(int n, Point point) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/edu/rpi/legup/ui/WrapLayout.java
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public WrapLayout(int align, int hgap, int vgap) {

/**
* Returns the preferred dimensions for this layout given the
* <image>visible</image> components in the specified target container.
* visible components in the specified target container.
*
* @param target the component which needs to be laid out
* @return the preferred dimensions to lay out the
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public DropShadowBorder(Color lineColor, int lineWidth, int shadowSize,
}

/**
* @inheritDoc
*
*/
public void paintBorder(Component c, Graphics graphics, int x, int y, int width, int height) {
/*
Expand Down Expand Up @@ -289,7 +289,7 @@ private Map<Position, BufferedImage> getImages(Graphics2D g2) {
}

/**
* @inheritDoc
*
*/
public Insets getBorderInsets(Component c) {
int top = 4 + (showTopShadow ? lineWidth + shadowSize : lineWidth);
Expand All @@ -301,7 +301,7 @@ public Insets getBorderInsets(Component c) {
}

/**
* @inheritDoc
*
*/
public boolean isBorderOpaque() {
return true;
Expand Down

0 comments on commit a735dc1

Please sign in to comment.