Create a mode that does not generate intermediate files in SftpUpload. #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nissy0409240
commented
Jul 22, 2024
|
|
||
| _logger = logging.getLogger(__name__) | ||
|
|
||
| if _logger.isEnabledFor(logging.DEBUG): |
There was a problem hiding this comment.
I removed it because it was only used for debugging.
nissy0409240
commented
Jul 22, 2024
cliboa/template/Pipfile.above310
Outdated
| @@ -40,6 +40,7 @@ python-gnupg = "==0.4.8" | |||
| openpyxl = "==3.0.9" | |||
| pyminizip = "==0.2.5" | |||
| psycopg2 = "==2.9.1" | |||
| numpy = "<2" | |||
There was a problem hiding this comment.
I also made some changes to this p-r to pass the unit test.
If there are any conflicts, I will deal with them.
yasuhiro-ohba
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief
Create a mode that does not generate intermediate files in SftpUpload.
Points to Check
Test
Confirmed
I was able to transfer files using the modified SftpUpload class.
I was able to transfer files by adding the put_intermediation option.
I was able to transfer files by specifying None for the put_intermediation option.
The contents of the file did not change before and after the transfer.
I confirmed the above.
Review Limit
As soon as possible.