Add output log for targetfile to CsvConvert class #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nissy0409240
requested review from
bo-naoki-okamoto,
bp-gen-aihara and
yasuhiro-ohba
|
テスト落ちる件は最新版のpipenvのバグ起因です |
bp-gen-aihara
approved these changes
Nov 17, 2021
|
https://github.com/BrainPad/cliboa/blob/master/cliboa/scenario/transform/file.py#L138 |
yasuhiro-ohba
approved these changes
Nov 18, 2021
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
=========================================
Coverage ? 79.28%
=========================================
Files ? 67
Lines ? 3524
Branches ? 0
=========================================
Hits ? 2794
Misses ? 730
Partials ? 0 Continue to review full report at Codecov.
|
|
pipenvの修正が完了したためテストが通るようになりました |
yasuhiro-ohba
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief
Add output log for targetfile to CsvConvert class
Test
Not necessary
Review Limit
At the timing of your hand