Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflow): 🐛 fixed failing test workflow #827

Merged
merged 31 commits into from
May 18, 2024
Merged

fix(workflow): 🐛 fixed failing test workflow #827

merged 31 commits into from
May 18, 2024

Conversation

WasiqB
Copy link
Member

@WasiqB WasiqB commented May 4, 2024

Closes: #826

Type of changes?

  • Bug fixes: Non-breaking change which fixes an issue
  • New feature: Non-breaking change which adds a new feature
  • Performance improvement: Non-breaking change which improves performance
  • Documentation: Non-breaking change which improves documentation
  • Other: Non-breaking change which does not fit into the above categories
  • Breaking change: A breaking change which requires a new version of the library

Checklist for Java project

  • Change not related to Java project

Following checklists are optional if above checkbox is selected:

  • Copyright banner comment added to newly added files, except *.md, *.yml, *.json?
  • Proper JavaDoc updated in main and test classes for all public classes and methods?
  • Tests added for changes?
  • Tests are passing locally?
  • Check style checks are passing locally?
  • Test coverage is at least 80% for newly added changes?
  • There are no SonarCloud issues?
  • README updated? (if applicable)
  • Documentation website updated for the PR raised?

Checklist for Website

  • Change not related to Website project

Following is optional if above checkbox is selected:

  • Lint check passes locally?
  • Prettier check passes locally?
  • Build command working fine locally?

Reviewers

@BoykaFramework/boyka-core

IMPORTANT: Make sure to check the Allow edits from maintainers box below this window

@WasiqB WasiqB self-assigned this May 4, 2024
@github-actions github-actions bot added the 🐛 pr: bug fix PR which fixes a bug label May 4, 2024
WasiqB added 27 commits May 4, 2024 22:28
Copy link

sonarcloud bot commented May 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@WasiqB WasiqB marked this pull request as ready for review May 18, 2024 12:36
@WasiqB WasiqB requested a review from a team as a code owner May 18, 2024 12:37
@WasiqB WasiqB requested a review from mfaisalkhatri May 18, 2024 12:37
@WasiqB WasiqB merged commit c4b4d8a into main May 18, 2024
23 checks passed
@WasiqB WasiqB deleted the issue-826 branch May 18, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 pr: bug fix PR which fixes a bug
Projects
Development

Successfully merging this pull request may close these issues.

🐛 New Bug: Test workflow fails on Mac OS agent
1 participant