Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): ✨ added browser version feature #794

Merged
merged 7 commits into from
Mar 9, 2024
Merged

feat(java): ✨ added browser version feature #794

merged 7 commits into from
Mar 9, 2024

Conversation

WasiqB
Copy link
Member

@WasiqB WasiqB commented Mar 8, 2024

Closes: #792

Type of changes?

  • Bug fixes: Non-breaking change which fixes an issue
  • New feature: Non-breaking change which adds a new feature
  • Performance improvement: Non-breaking change which improves performance
  • Documentation: Non-breaking change which improves documentation
  • Other: Non-breaking change which does not fit into the above categories
  • Breaking change: A breaking change which requires a new version of the library

Checklist for Java project

  • Change not related to Java project

Following checklists are optional if above checkbox is selected:

  • Copyright banner comment added to newly added files, except *.md, *.yml, *.json?
  • Proper JavaDoc updated in main and test classes for all public classes and methods?
  • Tests added for changes?
  • Tests are passing locally?
  • Check style checks are passing locally?
  • Test coverage is at least 80% for newly added changes?
  • There are no SonarCloud issues?
  • README updated? (if applicable)
  • Documentation website updated for the PR raised?

Checklist for Website

  • Change not related to Website project

Following is optional if above checkbox is selected:

  • Lint check passes locally?
  • Prettier check passes locally?
  • Build command working fine locally?

Reviewers

@BoykaFramework/boyka-core

IMPORTANT: Make sure to check the Allow edits from maintainers box below this window

@WasiqB WasiqB self-assigned this Mar 8, 2024
@github-actions github-actions bot added the 🚀 pr: new feature PR which introduces new features label Mar 8, 2024
Copy link

sonarcloud bot commented Mar 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
70.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@WasiqB WasiqB marked this pull request as ready for review March 9, 2024 11:48
@WasiqB WasiqB requested a review from a team as a code owner March 9, 2024 11:48
@WasiqB WasiqB merged commit 837476e into main Mar 9, 2024
23 of 24 checks passed
@WasiqB WasiqB deleted the issue-792 branch May 22, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 pr: new feature PR which introduces new features
Projects
Development

Successfully merging this pull request may close these issues.

⭐ New feature: Support for testing the web application on different browser versions
1 participant