Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(Internal): 📝 updated missing docs #407

Merged
merged 3 commits into from
Mar 4, 2023
Merged

docs(Internal): 📝 updated missing docs #407

merged 3 commits into from
Mar 4, 2023

Conversation

WasiqB
Copy link
Member

@WasiqB WasiqB commented Mar 3, 2023 •
edited
Loading

Closes: #384

Type of changes?

  • Bug fixes: Non-breaking change which fixes an issue
  • New feature: Non-breaking change which adds a new feature
  • Performance improvement: Non-breaking change which improves performance
  • Documentation: Non-breaking change which improves documentation
  • Other: Non-breaking change which does not fit into the above categories
  • Breaking change: A breaking change which requires a new version of the library

Checklist for Java project

  • Change not related to Java project

Following checklists are optional if above checkbox is selected:

  • Copyright banner comment added to newly added files, except *.md, *.yml, *.json?
  • Proper JavaDoc updated in main and test classes for all public classes and methods?
  • Tests added for changes?
  • Tests are passing locally?
  • Check style checks are passing locally?
  • Test coverage is at least 80% for newly added changes?
  • There are no SonarCloud issues?
  • README updated? (if applicable)
  • Documentation website updated for the PR raised?

Checklist for Website

  • Change not related to Website project

Following is optional if above checkbox is selected:

  • Lint check passes locally?
  • Prettier check passes locally?
  • Build command working fine locally?

Reviewers

@BoykaFramework/boyka-core

IMPORTANT: Make sure to check the Allow edits from maintainers box below this window

@WasiqB
docs(Internal): 📝 updated missing docs
c33854d 
also fixed few minor issues wrt logging
@WasiqB WasiqB self-assigned this Mar 3, 2023
@github-actions github-actions bot added the 📝 pr: documentation PR which adds only documentation changes label Mar 3, 2023
@ghost
Copy link

ghost commented Mar 3, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@WasiqB WasiqB marked this pull request as ready for review March 3, 2023 17:50
@WasiqB WasiqB requested a review from a team as a code owner March 3, 2023 17:50
@sonarcloud
Copy link

sonarcloud bot commented Mar 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

42.9% 42.9% Coverage
0.0% 0.0% Duplication

@WasiqB WasiqB merged commit 33addc8 into develop Mar 4, 2023
@WasiqB WasiqB deleted the issue-384 branch March 4, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfaisalkhatri mfaisalkhatri Awaiting requested review from mfaisalkhatri mfaisalkhatri was automatically assigned from BoykaFramework/boyka-core

Assignees

@WasiqB WasiqB

Labels
📝 pr: documentation PR which adds only documentation changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@WasiqB