Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: simplify string formatting for readability #1072

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

hamirmahal
Copy link

closes #1071.

Copy link

vercel bot commented Oct 21, 2024

@hamirmahal is attempting to deploy a commit to the Gloo Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't cause any user-facing changes.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 709ae7d in 39 seconds

More details
  • Looked at 2847 lines of code in 77 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. engine/baml-runtime/src/internal/llm_client/orchestrator/call.rs:44
  • Draft comment:
    The string formatting here has been updated to use the new Rust syntax, which improves readability and is consistent with the PR's intent.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The PR aims to simplify string formatting using the new Rust syntax. This change is consistent with the PR's intent and improves readability.
2. engine/baml-runtime/src/internal/llm_client/orchestrator/stream.rs:51
  • Draft comment:
    The string formatting here has been updated to use the new Rust syntax, which improves readability and is consistent with the PR's intent.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The PR aims to simplify string formatting using the new Rust syntax. This change is consistent with the PR's intent and improves readability.
3. engine/language_client_codegen/src/dir_writer.rs:71
  • Draft comment:
    The string formatting here has been updated to use the new Rust syntax, which improves readability and is consistent with the PR's intent.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The PR aims to simplify string formatting using the new Rust syntax. This change is consistent with the PR's intent and improves readability.

Workflow ID: wflow_ye3HdeSn0fwbBqHa


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@sxlijin
Copy link
Collaborator

sxlijin commented Oct 21, 2024

Hi there- thanks for making this PR! We always love to see new contributors :)

Can I ask if there's something you're working on right now that this makes easier? Or is there automation (e.g. cargo fix or cargo lint) that you're using for this?

I primarily ask because this touches a lot of code and while I'd love to merge this, we do have some really big WIPs that will conflict with this change and if possible, I'd like to defer this until those land.

@hamirmahal
Copy link
Author

Hello! You're welcome.

That's fine. Feel free to ping me once the large WIPs are through: I can take another look at this then. I wouldn't want to create a bunch of merge conflicts for any large in-progress pull requests.

@sxlijin
Copy link
Collaborator

sxlijin commented Oct 22, 2024

Amazing - I'll set a reminder to check back in on this in a week, and make sure that the rest of us know so that we can keep a window open for this to go in when they're in.

@hellovai
Copy link
Contributor

hi @hamirmahal the code is updated now! thanks for your patience

@hamirmahal
Copy link
Author

You're welcome. I'll take another look at this.

@hamirmahal hamirmahal force-pushed the style/simplify-string-formatting-for-readability branch from 709ae7d to 3ebab7b Compare November 17, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

format! statements can be simplified
3 participants