This repository has been archived by the owner on Nov 26, 2018. It is now read-only.
[WIP] Docker / go 1.6 updates #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also Add docker-compose that includes db bootstrapping, and redis
TODO: Add build steps for doing prod builds for docker.
| @@ -109,7 +110,17 @@ type RedisQueue struct { | |||
| func NewRedisQueue() Queue { | |||
| redisUrlString := os.Getenv("REDIS_PLUGIN_QUEUE_URL") | |||
| if redisUrlString == "" { | |||
| glog.Fatal("REDIS_PLUGIN_QUEUE_URL cannot be empty.\nexport REDIS_PLUGIN_QUEUE_URL=redis://host:port/db_number") | |||
|
|
|||
| // try to connect via docker links if they exist. | |||
There was a problem hiding this comment.
Hmm, not sure how I feel about having Docker related stuff in the code. It's easy enough to build up the environment variable when starting the containers, right?
|
Thanks @gaker! I left some notes in there... I think we'll need a little documentation too. Guessing a small section in the |
ipmb
force-pushed
the
master
branch
2 times, most recently
from
e4efebd to
f77af5b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salient changes:
as well as the required redis container.
but try to setup from docker links if
STORAGE_URLandQUEUE_URLare not in the environment.
govendor.queries work).