Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(es-module) strtok3 package uses Buffer without import #629

Closed
Borewit opened this issue Dec 10, 2021 · 1 comment · Fixed by #632
Closed

(es-module) strtok3 package uses Buffer without import #629

Borewit opened this issue Dec 10, 2021 · 1 comment · Fixed by #632
Labels
bug

Comments

@Borewit
Copy link
Owner

Borewit commented Dec 10, 2021

I've got another problem in strtok3 package as it uses Buffer without import. For example when file-type use tokenizer.readToken it results in an error.

Originally posted by @AaronPorts in sindresorhus/file-type#502 (comment)
@Borewit Borewit added the bug label Dec 10, 2021
@Borewit Borewit changed the title (es-module) strtok3 package as it uses Buffer without import (es-module) strtok3 package uses Buffer without import Dec 10, 2021
Borewit added a commit that referenced this issue Dec 10, 2021
@Borewit
Explicit node:buffer import
3ddafcf 
Resolves #629
Borewit added a commit that referenced this issue Dec 10, 2021
@Borewit
Explicit node:buffer import
04cdfb6 
Resolves #629
@Borewit Borewit mentioned this issue Dec 10, 2021
Merged
@Borewit Borewit linked a pull request Dec 10, 2021 that will close this issue
Explicit node:buffer import #632
Merged
@Borewit
Copy link
Owner Author

Borewit commented Aug 4, 2022

Was resolved in v7.0.0-alpha.2

@Borewit Borewit closed this as completed Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explicit node:buffer import Borewit/strtok3
1 participant
@Borewit