Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code smell fixes #22

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Code smell fixes #22

merged 1 commit into from
Mar 5, 2023

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Mar 4, 2023

Changes:

  • Simplifies expressions with binary operators
  • Remove fully qualified Object references, use import instead
  • Remove unnecessary throws
  • Remove, presumably unused / not required to import directly, dependencies:
    • asm:asm:3.3.1
    • commons-beanutils:commons-beanutils-core:1.8.3
    • commons-collections:commons-collections:3.2.2
    • commons-jexl:commons-jexl:1.0
    • org.dom4j:dom4j:2.1.4
    • xml-apis:xml-apis:1.4.01
    • com.sun.activation:javax.activation:1.2.0

@Borewit Borewit self-assigned this Mar 4, 2023
@Borewit Borewit added the debt label Mar 4, 2023
@Borewit Borewit mentioned this pull request Mar 4, 2023
build.gradle Outdated Show resolved Hide resolved
- Remove unused dependencies
- Simplifies expressions with binary operators
- Remove fully qualified Object references, use import instead
- Remove unnecessary throws
@Borewit Borewit merged commit cbcf21b into main Mar 5, 2023
@Borewit Borewit deleted the code-fixes branch March 5, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant