Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist open playlists in configuration file #141

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Mar 8, 2023

Store open playlist-editors in configuration file options.json on exit and reloads the playlists (at least those which still exist).

Resolves #70

@Borewit Borewit added the enhancement Request or implementation of new feature label Mar 8, 2023
@Borewit Borewit self-assigned this Mar 8, 2023
@Borewit
Copy link
Owner Author

Borewit commented Mar 8, 2023

Build: listFix_2.6.0-PR141-34.exe

@Borewit
Copy link
Owner Author

Borewit commented Mar 9, 2023

Original sequence of tabs is not preserved, I will change that.

@touwys
Copy link

touwys commented Mar 9, 2023

Testing: listFix_2.6.0-PR141-34

Original sequence of tabs is not preserved, I will change that.

Thank you, I noted that, and I herewith confirm this positional change of the restored tabs, does occur.

✔️ During testing, I loaded many different playlist combinations, and every one of them closed and opened efficiently upon restart — except for the aforesaid incorrect tab sequence. So I guess it's safe to move onto the next stage of your plan, once the sequence issue is sorted out.


ℹ️ The dragging and dropping of playlists into the Editor work really well. During the current test, however, I discovered that something is amiss — support for the dragging and dropping of playlists from the Playlist Directory directly into the Playlist Editor. I propose that you consider adding it, in order to fulfil the drag-and-drop function.


@Borewit Borewit force-pushed the persist-open-playlists branch 2 times, most recently from dccb692 to 8b81a4e Compare March 9, 2023 13:43
@touwys
Copy link

touwys commented Mar 9, 2023

Original sequence of tabs is not preserved, I will change that.

@Borewit : Did you also catch that not only are the tabs getting restored out of sequence, the tab that was busy getting edited upon exiting, is not getting restored as the active one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request or implementation of new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Save Layout" to "Confirm Close" Dialogue
2 participants