-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve drag-and-drop playlist implementation #136
Conversation
Build: listFix_2.6.0-PR136-29.exe If you have time to review @touwys, it's all yours |
Thanks, I am onto it. |
Did you read my comment about the Themes, here? #106 (comment) |
Testing: listFix_2.6.0-PR136-29.exe
Not sure what you mean by this? ℹ️ What is missing, is support for dragging playlists from folders in the PLD, to dropping it into the PLE. |
Be able to drag in a playlist like this, (the visualization may deviate)
Yes I did, I agree with that. Better one solid theme, than 5 which are so so. There are still so many area's this application could improve. Sometimes I don't know where to start. I want to give JavaFx a try to see if that is doable and maybe a better investment for the future. But also also would like to utilize Lizzy better, to concentrate all the playlist functionality in there. Currently it is only used for iTunes playlists. And to distribute ListFix an AppImage. |
I cannot test this just now, to figure it out. Probably, tomorrow. How does it differ from the first item on your list: "Allows to drag playlists on playlist-editor,..."? About the Themes: We agree then. However, on having second thoughts, it might be worthwhile to consider retaining just one dark theme along with light default. Should I go ahead and post the proposed theme modification as an issue/improvement?
You have made extremely good progress, and we already have a functional app, where a short time ago we had no such thing Therefore, don't worry too much, and do not try to do too many things at a time. Stick to ticking off the "boxes" like you're doing now, and just keep your focus, and the pace, steady. Although I do not know the first thing about programming/coding, I really want to assist you, by helping you to determine some of the listFix() priorities from a user point of view. For instance, I think the next in line for your attention should be saving the current layout (or session) upon closing the app, because it's such a drag on the user having to start over before commencing to edit again, a previously abandoned, incomplete session. |
64b5f79
to
cd0cc6b
Compare
Dragging the playlist to this location will assume the playlists should be opened, as it is not dragged into another playlist
Let's postpone the detailed visual improvements, I started playing with JavaFX, I may redo the entire GUI. Will take a bit of time, it's like 4000 km journey by foot.
I can make some progress in that area. |
OK, then I have tested this too, already, and found it is working perfectly well just like the other two drag and drop operations. A full score!
Yes, from a practicality point of view, the GUI is not so important at all, unless it interferes with operations. Let me know if there perhaps is something specific you want me to look out for in this test build? BTW, is it purely coincidental, or have you done some work to improve the PLAY-button display: |
Improved drag-and-drop behavior:
Debt:
Technical debt remaining:
Depends on
io.github:borewit:lizzy:1.2.0