Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant ways to open and repair a playlists #41

Closed
Borewit opened this issue Jan 30, 2023 · 4 comments
Closed

Redundant ways to open and repair a playlists #41

Borewit opened this issue Jan 30, 2023 · 4 comments

Comments

@Borewit
Copy link
Owner

Borewit commented Jan 30, 2023

          **Testing listFix_2.5.0**

I find myself chasing windmills. I am quite uncertain at the moment about the way certain actions, when executed, are expected to behave. The nomenclature is confusing, to say the least. Underneath, there follows is a screenshot of one such example:

For instance: Are "Exact Matches Repair" (Ctrl + M) and "Find Exact Matches" one and the same thing — only they are accessible from two different locations? As they stand now, their actions do not match.

Observation: I made two different playlists. One for a single disc taken from a multi-disc box set, and one for a number of tracks that I randomly selected. I proceeded to move the playlist out of their respective folders in order to break the list-to-track relationship, and then I copied the two test folders over to the roots of three different hard drives, plus one test-folder copied to a subdirectory on one of the drives. All the test playlists repaired properly. It should be noted that even the "Find Exact Matches" (binocular icon) action turned in fully repaired playlists. However, when the same "Find Exact Matches" (binocular icon) action is executed on previously made, older playlists, it still behaves as reported before — for all the releases tested up to now. This issue appears to be one that needs to be ironed out, and any suggestions on what the cause might be and how to proceed to nail it down, are welcome indeed.

Screenshot:

image

Question:

"Exact Matches Repair" (Ctrl + M): Screenshot of action-window which opens. What action is required here, which is not already available elsewhere? Does it only open a playlist to repair in some way other than what is already available?

image

Originally posted by @touwys in #28 (comment)

@Borewit
Copy link
Owner Author

Borewit commented Jan 30, 2023

Does it only open a playlist to repair in some way other than what is already available?

I checked the code, it seems to be redundant to the existing way of opening a playlist and then used the button (binocular icon). Very much in line how the coding is done, many redundant lines of code 🤣.

I have no problem stripping the menu option out, as I fail to see the added value.

@touwys
Copy link

touwys commented Jan 31, 2023

@Borewit:

I have no problem stripping the menu option out, as I fail to see the added value.

Would you be inclined to look at a few other proposals for possible app enhancements, once you have ironed out the operational wrinkles? There are some that I would like to share with you sometime ahead.

@Borewit
Copy link
Owner Author

Borewit commented Jan 31, 2023

here are some that I would like to share with you sometime ahead.

Sure, feel free to raise issues for those.

@Borewit
Copy link
Owner Author

Borewit commented Oct 4, 2023

I think this is resolved

@Borewit Borewit closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants