Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the "Exact Matches Repair...." feature #154

Closed
touwys opened this issue Apr 3, 2023 · 7 comments · Fixed by #157
Closed

Drop the "Exact Matches Repair...." feature #154

touwys opened this issue Apr 3, 2023 · 7 comments · Fixed by #157

Comments

@touwys
Copy link

touwys commented Apr 3, 2023

The "Repair" menu could be trimmed by removing the first entry, namely: "Exact Matches Repair". This action is already more suitably taken care of in the editor, and it does not really belong here with the other two.

image

@Borewit Borewit changed the title Trimming the "Repair" Menu: Screenshot Trimming the "Repair" Menu Apr 4, 2023
@Borewit Borewit changed the title Trimming the "Repair" Menu Drop the "Exact Matches Repair...." feature Apr 4, 2023
@Borewit
Copy link
Owner

Borewit commented Apr 4, 2023

I noticed there is different terminology:

There are 2 methods of fixing playlists:

  1. Unresolved playlist entries are automatically replaced with closest match found
  2. Unresolved playlist entries are shown with a number of alternative, sorted by the closest match

Via the "Playlist Editor", method # 1, Fix everything
Via the "Playlist Editor", method # 1, Find Exact Match

Via the "Playlist Directories", method # 1, "Quick", "Quick Batch Repair"
Via the "Playlist Directories", method # 2, "Deep", "Deep Batch Repair"

Where "Quick Batch Repair" can handle multiple playlists (batch) selected in the playlist directories
Where "Deep Batch Repair" can handle multiple playlists (batch) selected in the playlist directories

Via the Repair menu:
"Quick Repair Currently Opened Playlists", uses method # 1, in batch mode on all open playlists in editor
"Deep Repair Currently Opened Playlists", uses method # 2, in batch mode on all open playlists in editor

And then there is the "Exact Matches Repair....", which based on picking a file (or more, did not try). It indeed does not make sense to me. I have no problem cutting that one out.

I am summarizing all of this, as I am not fan of the terminology.

Also strongly related to:

@touwys
Copy link
Author

touwys commented Apr 4, 2023

I noticed there is different terminology:

Yes, I also noticed that. It puzzles me why it has been done that way, because, for the user, the different descriptions seem to infer slightly different processes, and that can be quite confusing.

It will certainly represent a huge improvement, once you have fixed that.

@touwys
Copy link
Author

touwys commented Apr 4, 2023

Addendum: Are you perhaps considering to strip all the other editing access points, and limit it to the most suitable one, the Playlist Editor?

@Borewit
Copy link
Owner

Borewit commented Apr 4, 2023

Addendum: Are you perhaps considering to strip all the other editing access points, and limit it to the most suitable one, the Playlist Editor?

That is indeed what more or less what I had in mind in #41. It's quite a chunk of work we trash, but don't see a lot of added values in the "batched" modes.

What do you think about that @touwys?

@touwys
Copy link
Author

touwys commented Apr 4, 2023

It's quite a chunk of work we trash, but don't see a lot of added values in the "batched" modes.

Personally, I do actually find the batch mode quite useful. Once the exact matches command is dropped, can the select closest matches batch mode not be moved to the Editor?

@Borewit
Copy link
Owner

Borewit commented Apr 4, 2023

Personally, I do actually find the batch mode quite useful.

So let's fix the cancellation, like you suggested in #155.

can the select closest matches batch mode not be moved to the Editor?

The scope of the Playlist Editor Toolbar are buttons for functions which apply to that playlist only. So I don't think that makes it better.

@Borewit Borewit pinned this issue Apr 4, 2023
@touwys
Copy link
Author

touwys commented Apr 4, 2023

So let's fix the cancellation, like you suggested in #155.

But the terminlogy still are to be fixed for uniformity's sake?

The scope of the Playlist Editor Toolbar are buttons for functions which apply to that playlist only. So I don't think that makes it better.

Yes, I do realise that, but I was thinking in line of this proposal, which sees that the tab-functions are eventually extended.

@Borewit Borewit unpinned this issue Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants