-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THC TDA #12
THC TDA #12
Conversation
Plan after call:
I think this should make everything interface nicely without chaning much existing code |
I've changed some stuff around, made variable names more consistent with the DF implementation, and I think things are looking good. Still need tests, and to stress test the miscellaneous features in the Not sure what our merge policy here is - perhaps this should just live in a development branch until we have a usable interface with the THC integral generation. |
Can we move the MPI stuff to a new branch? Then we can look to getting this PR merged this week, I think it's ready to go |
Branched MPI changes and reverted to pre MPI |
on second thought, maybe we want to get the self-consistency working before merging |
LGTM, great stuff @mkakcl |
thc.py
introducing the new function of completing TDA calculations using THC integrals. Using this method should scale as N^3 in comparison to the previous Cholesky decomposition method (scales as N^4)ints.py
. Future implementations will hopefully directly interface with a method to calculate THC ERIs.