Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RTL optional #3510

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Make RTL optional #3510

merged 2 commits into from
Mar 3, 2020

Conversation

Rokt33r
Copy link
Member

@Rokt33r Rokt33r commented Mar 3, 2020

Description

This pr makes rtl completely optional and changes RTL hotkey for Windows and Linux app.

Issue fixed

Fixes #3493, #3485

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)

Checklist:

  • ⚪ My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible
  • ⚪ This PR will modify the UI or affects the UX
  • ⚪ This PR will add/update/delete a keybinding

@Rokt33r Rokt33r added this to the v0.15.1 milestone Mar 3, 2020
@Rokt33r Rokt33r linked an issue Mar 3, 2020 that may be closed by this pull request
CTRL-Right toggles Left-to-Right #3485
Closed
@Rokt33r Rokt33r merged commit 87a737b into master Mar 3, 2020
@Rokt33r Rokt33r deleted the fix-rtl branch March 3, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.15.1
Development

Successfully merging this pull request may close these issues.

Add a setting to hide "rtl toggle button" CTRL-Right toggles Left-to-Right
1 participant
@Rokt33r