Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a setting to hide "rtl toggle button" #3493

Closed
Aaron-Bird opened this issue Feb 25, 2020 · 2 comments · Fixed by #3510
Closed

Add a setting to hide "rtl toggle button" #3493

Aaron-Bird opened this issue Feb 25, 2020 · 2 comments · Fixed by #3510
Labels
improvement request 🔨 Issue concerns an existing feature that needs improvement. ui/ux 💻 Issue is related to UI/UX. Currently used for a big rewrite that is occurring.

Comments

@Aaron-Bird
Copy link
Contributor

Aaron-Bird commented Feb 25, 2020 •
edited
Loading

Feature request:
Add a setting to hide "rtl toggle button"

In most cases this button is rarely used, and it is easy to confuse with the toggleMode Button.
1
@Aaron-Bird Aaron-Bird changed the title [Feature request] Add a setting to hide "rtl toggle button" Add a setting to hide "rtl toggle button" Feb 25, 2020
@Flexo013
Copy link
Contributor

Agreed that this button should not be in your face like it currently is. (Much less should it hijack a default key combo #3485.)

Adding this to the top menu bar in view should be sufficient.

@Flexo013 Flexo013 added improvement request 🔨 Issue concerns an existing feature that needs improvement. ui/ux 💻 Issue is related to UI/UX. Currently used for a big rewrite that is occurring. labels Feb 25, 2020
@Rokt33r
Copy link
Member

Rokt33r commented Feb 26, 2020

I'm sorry for making this trouble. I didn't review enough the PR, introducing RTL, at the first time. I totally agree with you. It must be presented optionally. This will be solved on this Sunday with #3485.

@Rokt33r Rokt33r mentioned this issue Mar 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement request 🔨 Issue concerns an existing feature that needs improvement. ui/ux 💻 Issue is related to UI/UX. Currently used for a big rewrite that is occurring.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make RTL optional BoostIO/BoostNote-Legacy
3 participants
@Flexo013 @Rokt33r @Aaron-Bird