Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip misplaced when scrolling down #3497

Closed
wants to merge 2 commits into from
Closed

Tooltip misplaced when scrolling down #3497

wants to merge 2 commits into from

Conversation

Aaron-Bird
Copy link
Contributor

@Aaron-Bird Aaron-Bird commented Feb 26, 2020

This modification is bad, maybe using js is better.
I think it can't be done with css only, because overflow-y: auto and overflow-x: visible cannot be used on the same element
I closed this pr and opened another one to solve the problem

Description

Tooltip misplaced when scrolling down.
#3490 (review)

before

Issue fixed

after
This pr caused some style changes.
May these changes be accepted?
2

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • ⚪ My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@Aaron-Bird Aaron-Bird changed the title Fix bug Tootip misplaced when scrolling down Feb 26, 2020
@Aaron-Bird Aaron-Bird changed the title Tootip misplaced when scrolling down Tooltip misplaced when scrolling down Feb 26, 2020
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Feb 26, 2020
@Aaron-Bird Aaron-Bird closed this Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review ❇️ Pull request is awaiting a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants