Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fix to work markdownlint#3147 #3285

Merged
merged 3 commits into from
Oct 28, 2019
Merged

Fix/fix to work markdownlint#3147 #3285

merged 3 commits into from
Oct 28, 2019

Conversation

roottool
Copy link
Contributor

Description

I defined some script tags and a stylesheet in lib\main.development.html but I didn't define them in lib\main.production.html then.
So I define them in lib\main.production.html.

And I removed a single quotation of the key names.
Because other key names in browser\components\CodeEditor.js were not enclosed in a single quotation.

Screenshot

fixToWorkMarkdownlint

Issue fixed

#3147

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Oct 18, 2019
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Oct 20, 2019
@BramManuel
Copy link

Can this be merged please? 😊

@Rokt33r Rokt33r added this to the v0.14.0 milestone Oct 28, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Oct 28, 2019
@Rokt33r Rokt33r merged commit 3ef4855 into BoostIO:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants