Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 4.x and 5.x compatibility #3105

Closed
wants to merge 1 commit into from

Conversation

clone1612
Copy link
Contributor

Description

This pull request updated the project to Electron v5.0.6 (the latest version) and includes the necessary fixes for breaking changes introduced by Electron v4.x and v5.x

Issue fixed

#3100

Type of changes

  • 🔵 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • 🔵 Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔵 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔵 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jul 5, 2019
@ZeroX-DG ZeroX-DG requested a review from Rokt33r July 5, 2019 10:46
@ZeroX-DG ZeroX-DG added needs extra review 🔎 Pull request requires review from an additional reviewer. awaiting review ❇️ Pull request is awaiting a review. and removed awaiting review ❇️ Pull request is awaiting a review. needs extra review 🔎 Pull request requires review from an additional reviewer. labels Jul 20, 2019
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Jan 29, 2020

I'm sorry for this but I'll close this PR since it has been covered by these PR:

But thank you for your contribution anyway 😃 Feel free to open another PR for upgrading to electron 5 or newer if you want to.

@ZeroX-DG ZeroX-DG closed this Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review ❇️ Pull request is awaiting a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants