Enable Markdown lint option

[AWolf81]

After merging #2983 we can add this to toggle markdownLinting.

I've based this on branch roottool:add-markdownlint-rules-form from PR #2983

Description

• Added enableMarkdownLint setting
• Add/remove gutter based on enableMarkdownLint

Issue fixed

#3025

Type of changes

• ⚪ Bug fix (Change that fixed an issue)
• ⚪ Breaking change (Change that can cause existing functionality to change)
• ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
• 🔘 Feature (Change that adds new functionality)
• ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

• 🔘 My code follows the project code style
• ⚪ I have written test for my code and it has been tested
• 🔘 All existing tests have been passed
• 🔘 I have attached a screenshot/video to visualize my change if possible

Todos:

• Fix gutter toggling

Discussion

• Is the position of the option OK or should it be closer to the config area for markdown lint? I've moved it to the textarea because I think that location is better.
• Is setting enableMarkdownLint to false by default OK?
• Any ideas how I can fix the gutter toggling? It seems to not display the linting errors after re-enabling the linting. I've found a work-around by toggling the gutter with style.display and keep it in the config. Not sure if there is a better way to handle it but it's working now.

Screenshot

Current setting

Below is the location from my first draft (changed it to the above location)

[ZeroX-DG]

I don't think throwing an error here is a good thing to do because it will make the app unusable. I think you should put something more "user-friendly" for example not applying the lint config and display error message above the custom lint config box in the setting.

[AWolf81]

Yes, you're right. It's bad to throw an error with-out handling it.
How can I add the error message display? I've tried to change the throw err to

eventEmitter.emit('APP_SETTING_ERROR')
return

But I don't like how it's working. It first shows success message and then the error occured message. It happens pretty fast - short flicker of the green message. Also on a second click it won't show the error again.

The catch can be triggered by entering invalid json for the custom markdown lint rule and then press the save button.

[AWolf81]

A custom error message wasn't working - not sure why. I wanted to add something like: Failed to apply custom linting rule.

Tried it with eventEmitter.emit('APP_SETTING_ERROR', {message: 'Failed to apply...'})

[ZeroX-DG]

And please remove all console.log unless you think it's useful for debugging and bug reporting in the future.

[Rokt33r]

Submit this pr to https://issuehunt.io/r/BoostIO/Boostnote/issues/3038 :)

[judsoniv]

Thank you! I've enabled linting and configured it the way I want. Thank you for being open to the feedback.