Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #2844] Grammar Error In Notes #2856

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

K-Sato1995
Copy link
Contributor

@K-Sato1995 K-Sato1995 commented Jan 31, 2019

Description

Fixed grammar error in notes. #2844

Issue fixed

Changed a sentence from We think developers who has skill and did great things must be rewarded properly. to We think developers who have skills and do great things must be rewarded properly.

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • 🔘: Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@Rokt33r
Copy link
Member

Rokt33r commented Feb 1, 2019

Dang it! 🤣 Thanks!

@Rokt33r Rokt33r added the approved 👍 Pull request has been approved by sufficient reviewers. label Feb 1, 2019
@Rokt33r Rokt33r added this to the v0.11.14 milestone Feb 1, 2019
@Rokt33r Rokt33r merged commit 885f656 into BoostIO:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved 👍 Pull request has been approved by sufficient reviewers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants