Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pt br translations #2761

Merged
merged 3 commits into from
Jan 7, 2019
Merged

Pt br translations #2761

merged 3 commits into from
Jan 7, 2019

Conversation

abnersajr
Copy link
Contributor

Description

This PR bring to us the Brazilian Portuguese translation.

Issue fixed

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • 🔘 Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 It's documentation, so the checklist items does not fit well to this scenario.

@ZeroX-DG ZeroX-DG added awaiting review ❇️ Pull request is awaiting a review. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! labels Dec 28, 2018
@ZeroX-DG
Copy link
Member

Thanks, do you know someone who can review this PR?

davidsilveira
davidsilveira reviewed Dec 28, 2018
View reviewed changes
docs/pt_BR/build.md Outdated Show resolved Hide resolved
davidsilveira
davidsilveira reviewed Dec 28, 2018
View reviewed changes
docs/pt_BR/build.md Outdated Show resolved Hide resolved
@abnersajr
Copy link
Contributor Author

All the suggestions were good. Thanks for your review @davidsilveira

@abnersajr
Copy link
Contributor Author

@ZeroX-DG need more reviewers?

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Jan 6, 2019

@Rokt33r for PR that provide translation, how many reviews do we need before we can merge it?

@Rokt33r
Copy link
Member

Rokt33r commented Jan 7, 2019

@ZeroX-DG I'm willing to accept any prs for the translation as long as there is no more reviewers in a week.

@Rokt33r Rokt33r removed help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! awaiting review ❇️ Pull request is awaiting a review. labels Jan 7, 2019
@Rokt33r Rokt33r merged commit 9ca5fa6 into BoostIO:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsilveira davidsilveira davidsilveira left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abnersajr @ZeroX-DG @Rokt33r @davidsilveira