handle all dropped images

[daiyam]

Description

The change allows to drop an image directly from the browser.
It also handles all the images dropped (from a browser or from a file explorer).

Issue fixed

• Feature Request: Adding attachments (specially images) by drag&drop from a web browser #2630

Type of changes

• ⚪ Bug fix (Change that fixed an issue)
• ⚪ Breaking change (Change that can cause existing functionality to change)
• 🔘 Improvement (Change that improves the code. Maybe performance or development improvement)
• ⚪ Feature (Change that adds new functionality)
• ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

• 🔘 My code follows the project code style
• ⚪ I have written test for my code and it has been tested
• 🔘 All existing tests have been passed
• ⚪ I have attached a screenshot/video to visualize my change if possible

[daiyam]

I've merged the previous PR #2473 into this one.

[edl7878]

come on, image is a must. but not work on windows for now. frustrated.

[daiyam]

@edl7878 is this PR not working on Windows?

[Rokt33r]

@daiyam I've checked this pr after merging the current master. It works fine in macOS, but doesn't work in Windows.
The problem is happened when the image url has query. In macOS, it just ignore query when loading image, but, in Windows, it also think query is a filename.

Uncaught Error: ENOENT: no such file or directory, open 'C:\....\hash.jpg?random=query'

Could you fix this and merge master into this pr?
I think we can finally fix pasting image issues after merging this pr.

[daiyam]

@Rokt33r is it from a browser or Explorer?

[Rokt33r]

@daiyam a browser!

[daiyam]

@Rokt33r I've found the issue. It's in the function copyAttachment(), the method path.extname() is called with the complete url. So with an url like http://..../image.jpg?random=query, it's give the extension.jpg?random=query...

[daiyam]

@Rokt33r your issue should be fixed but you should test it to make sure 😉

[ehhc]

Can you please add tests for the behaviour you want to fix? e.g. for a url containing a query

[Rokt33r]

@daiyam Could you add test cases for url with query?

[daiyam]

@Rokt33r @ehhc I've added the tests on urls.

I also had to fix the other tests so they are correctly testing the function.

[Rokt33r]

@daiyam Awesome! I think I could review this on the next Monday. Please wait a little bit more.
Btw, I've put some money to the issue. So please submit this pr to Issuehunt. https://issuehunt.io/repos/53266139/issues/2630

[Rokt33r]

@daiyam Ohno... This still does not work well in Linux.

Attachment folder ("/home/parallels/Boostnote/attachments/3981a37e-d182-4a95-b5fb-b589853323f3") did not exist..

It seems file extensions are gone somewhere. And I checked the attachments folder but there were nothing.

[daiyam]

@Rokt33r what were you doing? Because the log is normal if there were no images in the note.

[Rokt33r]

@daiyam I dragged and dropped an image from browser in Ubuntu Linux. Then, nothing was pasted and the only thing I got is that logs....

[daiyam]

@Rokt33r I found an issue with Firefox

In the following screenshot, the first "HTML" is from Firefox and the second is from Chromium.

[daiyam]

@Rokt33r I've tested on Ubuntu and it should be fine.

[Rokt33r]

Awesome! I'll deploy this tomorrow!