Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fold headings #2595

Merged
merged 1 commit into from
Nov 12, 2018
Merged

fold headings #2595

merged 1 commit into from
Nov 12, 2018

Conversation

daiyam
Copy link
Contributor

@daiyam daiyam commented Nov 10, 2018

Description

This change enables folding on headings.

screenshot

Issue fixed

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • 🔘 Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@daiyam daiyam mentioned this pull request Nov 10, 2018
Closed
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Nov 10, 2018
ZeroX-DG
ZeroX-DG approved these changes Nov 10, 2018
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 😄 Thank you for your non-stop contribution

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Nov 10, 2018
@Rokt33r Rokt33r merged commit 10d3adb into BoostIO:master Nov 12, 2018
@Rokt33r Rokt33r added next release (v0.11.12) and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Nov 12, 2018
@daiyam daiyam deleted the fold-headings branch November 12, 2018 18:12
@pihentagy
Copy link

Nice, do we have a keyboard shortcut to fold/unfold current section / all folds?
And fold more, fold less?

If yes, then boostnote can be used as an outliner 🎉

@daiyam
Copy link
Contributor Author

daiyam commented Dec 19, 2018

@pihentagy I have the PR #2597 for that 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daiyam @pihentagy @ZeroX-DG @Rokt33r