Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 2530 #2589

Merged
merged 4 commits into from
Nov 12, 2018
Merged

fix 2530 #2589

merged 4 commits into from
Nov 12, 2018

Conversation

arcturus140
Copy link
Contributor

@arcturus140 arcturus140 commented Nov 9, 2018

with issue #2530 tasks are not recognized correctly and compromized.

- [ ] `- [ ] a`
- [x] `- [ ] a`

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Nov 9, 2018

@arcturus140 can you fix this lint issue?

@ZeroX-DG ZeroX-DG added the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Nov 9, 2018
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Nov 9, 2018

@arcturus140 can you fix the lint again? there's still a lint error.
EDIT: Don't mind me 😄

@arcturus140
Copy link
Contributor Author

@ZeroX-DG uff, done 😅

Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Nov 9, 2018
@arcturus140 arcturus140 closed this Nov 9, 2018
@arcturus140 arcturus140 reopened this Nov 9, 2018
@Rokt33r Rokt33r added next release (v0.11.12) and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Nov 12, 2018
@Rokt33r Rokt33r merged commit 021bac5 into BoostIO:master Nov 12, 2018
@ZeroX-DG ZeroX-DG mentioned this pull request Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants