Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to disable scroll sync. #2542

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

nagledb
Copy link
Contributor

@nagledb nagledb commented Oct 26, 2018

While this doesn't solve the issues in #1811 it does at least allow us to regain some manual control over scrolling when sync isn't working well.

It may also be a useful feature in its own right. Sometimes I find myself wanting to scroll up to look at something else as reference while I'm editing. This makes that easier.

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Oct 27, 2018
@ZeroX-DG
Copy link
Member

According to your use case:

Sometimes I find myself wanting to scroll up to look at something else as reference while I'm editing. This makes that easier.

I think you should add a hotkey for this so that you won't have to change the setting everytime you want to do that.

Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Oct 28, 2018
@nagledb
Copy link
Contributor Author

nagledb commented Oct 29, 2018

Good idea on the hotkey. I'll see if I can figure how to to do that later.

@nagledb
Copy link
Contributor Author

nagledb commented Oct 31, 2018

I did some work on adding a hotkey but couldn't get it to work. I may revisit later but I currently don't plan to update this PR further.

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Nov 1, 2018

@nagledb OK, we will merge it later. Hope that you can implement hotkey for this in the next PR.
Here is my last PR for the hotkey system, maybe you can get some information from it:
#1929

@Rokt33r Rokt33r merged commit a43b0e6 into BoostIO:master Nov 2, 2018
@Rokt33r Rokt33r added next release (v0.11.12) and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants