delete tag through context menu #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroX-DG
requested changes
Oct 16, 2018
| @@ -65,7 +65,7 @@ class MarkdownNoteDetail extends React.Component { | |||
| } | |||
|
|
|||
| componentWillReceiveProps (nextProps) { | |||
| if (nextProps.note.key !== this.props.note.key && !this.state.isMovingNote) { | |||
| if (!this.state.isMovingNote && (nextProps.note.key !== this.props.note.key || nextProps.note.tags.length < this.props.note.tags.length)) { | |||
There was a problem hiding this comment.
This condition is really long and may confuse new contributors, can you assign some parts of the condition into variables with meaningful names?
There was a problem hiding this comment.
So that's is the reason for temporary variables I've seen in the code.
It's to increase the readability of the code 👍
if (
!this.state.isMovingNote &&
(
// if it's a new note
nextProps.note.key !== this.props.note.key ||
// if there is deleted tags
nextProps.note.tags.length < this.props.note.tags.length
)
) {
const isNewNote = nextProps.note.key !== this.props.note.key
const hasDeletedTags = nextProps.note.tags.length < this.props.note.tags.length
if (!this.state.isMovingNote && (isNewNote || hasDeletedTags)) {
I can see why it is more readable 😉
ZeroX-DG
added
awaiting changes 🖊️
ZeroX-DG
added
approved 👍
Rokt33r
added
next release (v0.11.11)
and removed
approved 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the possibility to delete a tag through its context menu.