-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix segmentation fault with glibc 2.28 #2484
fix segmentation fault with glibc 2.28 #2484
Conversation
package.json
Outdated
@@ -121,7 +121,7 @@ | |||
"css-loader": "^0.19.0", | |||
"devtron": "^1.1.0", | |||
"dom-storage": "^2.0.2", | |||
"electron": "2.0.7", | |||
"electron": "2.0.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crakoucas can you update it to the lastest one. Thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem
@crakoucas I was thinking more about the v2.0.11 but v3.0.3 is even better. But sadly, there is a small bug due to it (when the window is restored, its size is wrong). diff --git a/dev-scripts/dev.js b/dev-scripts/dev.js
index 000a1bfd..9698a2fe 100644
--- a/dev-scripts/dev.js
+++ b/dev-scripts/dev.js
@@ -49,7 +49,7 @@ function startServer () {
}
function startElectron () {
- spawn(electron, ['--hot', './index.js'])
+ spawn(electron, ['--hot', './index.js'], { stdio: 'inherit' })
.on('close', () => {
server.close()
})
diff --git a/lib/main-window.js b/lib/main-window.js
index fa54d5ce..86b70bea 100644
--- a/lib/main-window.js
+++ b/lib/main-window.js
@@ -14,6 +14,7 @@ const mainWindow = new BrowserWindow({
y: windowSize.y,
width: windowSize.width,
height: windowSize.height,
+ useContentSize: true,
minWidth: 500,
minHeight: 320,
autoHideMenuBar: showMenu, |
77ae44b
to
d87310b
Compare
@daiyam Done, but i can't reproduce the bug at home. Can you test it ? |
d87310b
to
a845d2e
Compare
Electron to V 3.0.3 Electron-gh-release to V2.0.4 Fix Bug restore windows size
a845d2e
to
a331d82
Compare
@crakoucas it's good for me (on macOS). |
I'll check this on Windows and Linux now. |
I confirmed it works well on Windows |
I can confirm that this patch fixes the startup issue on Ubuntu 18.10. |
I am having the same issue on Kubuntu 18.10. Is this fix going to be merged? |
Do we know when this fix will be merged in? |
I'll merge and publish this fix in this weekend. @ngamradt-turner @matthew-nm |
Btw sorry for being late... I'd just forgot about it... If you want something really badly, please ping me on our slack! |
This is fix 🐛
ERRROR : [1] 7816 segmentation fault (core dumped) in Ubuntu 18.10 and i think all linux distro with glibc 2.28
Issue