Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add French translations #2451

Merged
merged 4 commits into from
Nov 8, 2018
Merged

Add French translations #2451

merged 4 commits into from
Nov 8, 2018

Conversation

jacobherrington
Copy link
Contributor

French is my second language, so please make corrections if necessary!

locales/fr.json Outdated Show resolved Hide resolved
locales/fr.json Outdated Show resolved Hide resolved
Following up on PR feedback
locales/fr.json Outdated
"Snippet Default Language": "Langage par défaut d'un snippet",
"New Snippet": "Nouveau snippet",
"Custom CSS": "CSS personnalisé",
"Snippet name": "Nom de le snippet",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct: "Snippet name": "Nom du snippet",

locales/fr.json Outdated Show resolved Hide resolved
@daiyam
Copy link
Contributor

daiyam commented Oct 1, 2018

@jacobherrington Thanks for your translation 😃

Follow up on more PR feedback
@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Oct 5, 2018
@Rokt33r
Copy link
Member

Rokt33r commented Nov 6, 2018

@jacobherrington Could you fix the conflicts? I'm going to merge this pr before this weekend. So I can include this to the next release.

@Rokt33r Rokt33r added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Nov 6, 2018
@jacobherrington
Copy link
Contributor Author

Done @Rokt33r!

@Rokt33r Rokt33r added next release (v0.11.12) and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Nov 8, 2018
@Rokt33r Rokt33r merged commit 522a37b into BoostIO:master Nov 8, 2018
@Rokt33r
Copy link
Member

Rokt33r commented Nov 8, 2018

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants