Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tag autocomplete #2320

Merged
merged 6 commits into from
Sep 15, 2018
Merged

add tag autocomplete #2320

merged 6 commits into from
Sep 15, 2018

Conversation

daiyam
Copy link
Contributor

@daiyam daiyam commented Aug 21, 2018

This change adds tag autocomplete #192

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Aug 22, 2018
@ZeroX-DG
Copy link
Member

Hey @daiyam can you filter tags that has already been added ? I think it will be better.

@daiyam
Copy link
Contributor Author

daiyam commented Aug 25, 2018

@ZeroX-DG good idea! It's done.

@ZeroX-DG
Copy link
Member

Nice! LGTM

Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need Awesomeplete? I think this feature can be achieved by implement some React components.

@daiyam
Copy link
Contributor Author

daiyam commented Aug 26, 2018

@Rokt33r ya, a React component would be better but Awesomplete was faster to integrate.

@daiyam
Copy link
Contributor Author

daiyam commented Aug 26, 2018

@Rokt33r I removed awesomplete and replaced it with react-autosuggest.

@Rokt33r Rokt33r added next release (v0.11.10) and removed awaiting review ❇️ Pull request is awaiting a review. labels Sep 15, 2018
@Rokt33r Rokt33r merged commit f3c72e5 into BoostIO:master Sep 15, 2018
@Rokt33r
Copy link
Member

Rokt33r commented Sep 15, 2018

@daiyam LGTM. Btw, it doesn't work on snippet notes. Could you fix it too?

@daiyam daiyam deleted the tag-autocomplete branch September 15, 2018 07:42
@daiyam daiyam restored the tag-autocomplete branch September 15, 2018 08:15
@daiyam daiyam deleted the tag-autocomplete branch September 15, 2018 08:17
@daiyam
Copy link
Contributor Author

daiyam commented Sep 15, 2018

@Rokt33r I've submit the pull request #2400 to fix it.

@kazup01
Copy link
Member

kazup01 commented Oct 21, 2018

Hi @daiyam, I featured your contribution on release blog!
https://medium.com/boostnote/boostnote-v0-11-10-release-on-halloween-9bbe6d488fe8

@ehhc
Copy link
Contributor

ehhc commented Nov 9, 2018

@daiyam i just wanted to say that i like your feature. It's pretty cool :)

@daiyam
Copy link
Contributor Author

daiyam commented Nov 9, 2018

@ehhc thx

@arcturus140
Copy link
Contributor

yeah, best feature ever! 👍 I was longing for this from the first time I've used BN. So many redundant tags due to inconsistent letter case, plural / singular, synonyms, etc.

I had a script before to rename all tags to clean it all up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants