Mermaid dark theme rendering fix #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job.
|
|
I built Boostnote from this branch and tried the dark themes with the Mermaid sequence diagram. It seems to work great! 👍 |
sosukesuzuki
approved these changes
Jul 31, 2018
There was a problem hiding this comment.
Thank you for your contribution!:+1:
Also, You can receive the reward by issuehunt!:smile:
sosukesuzuki
added
next release (v0.11.9)
and removed
awaiting review ❇️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2215
Mermaid theme will change depending on whether the overall theme is light or dark.