Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Note Preview When Building From Source #2204

Open
alecbcs opened this issue Jul 13, 2018 · 8 comments
Open

Missing Note Preview When Building From Source #2204

alecbcs opened this issue Jul 13, 2018 · 8 comments
Labels
funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue.

Comments

@alecbcs
Copy link

alecbcs commented Jul 13, 2018

Current behavior

After building the application from source the note preview pane crashes with the error Uncaught Error: Cannot find module 'markdown-it-admonition'. I've checked and markdown-it-admonition does seem to be installed by npm.

screenshot from 2018-07-13 08-57-54
screenshot from 2018-07-13 08-58-36
This is the package.yaml for building the application on Solus.
screenshot from 2018-07-13 09-00-05

Expected behavior

The note preview pane should be visible.

Steps to reproduce

  1. Build application from source using pre-build
  2. Install & open the application

Environment

  • Version : 0.11.7
  • OS Version and name : Solus (3.999)
@cdayjr
Copy link
Contributor

cdayjr commented Jul 18, 2018

Hi, I had this same error after @saaguero helped me out fix my issue. In my issue they suggested installing markdown-it-admonition in the dist/Boostnote-linux-x64/resources/app folder. This works, but I wanted to use the rpm package. It turns out all you need to do is run yarn add markdown-it-admonition in the source code root folder after running yarn the first time, and this'll cause the packages to be built with it when you run the build commands.

@saaguero
Copy link
Contributor

@cdayjr I suggest that you open a PR with your fix so that it can be reviewed.

@cdayjr
Copy link
Contributor

cdayjr commented Jul 18, 2018

@saaguero Great idea, I submitted a pull request here: #2214

@borowskiio
Copy link

Hello,

Do we know when the fix for the issue will be merged?

Thanks!

@IssueHuntBot
Copy link

@BoostIO funded this issue with $30. Visit this issue on Issuehunt

Rokt33r added a commit that referenced this issue Aug 9, 2018
@Rokt33r
Copy link
Member

Rokt33r commented Aug 11, 2018

@dbjsy The fix will be shipped on the next Tuesday.

@borowskiio
Copy link

👍 @Rokt33r thank you :)

@kazup01 kazup01 added the bounty label Nov 7, 2018
@arcturus140
Copy link
Contributor

@Rokt33r what is the status of this issue? I think it has been merged into 0.11.9 and can be closed?

@Flexo013 Flexo013 added funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue. and removed 💵 Funded on IssueHunt labels Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
funded on issuehunt 💵 Issue has received funding that will be rewarded to the contributor solving this issue.
Projects
None yet
Development

No branches or pull requests

9 participants