remove console.logs & improve error handling

BoostIO · May 26, 2019 · 1a38771 · 1a38771
1 parent 02576c4
commit 1a38771
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/browser/components/CodeEditor.js b/browser/components/CodeEditor.js
@@ -642,8 +642,10 @@ export default class CodeEditor extends React.Component {
     try {
       Jsonlint.parse(customMarkdownLintConfig)
       lintConfigJson = JSON.parse(customMarkdownLintConfig)
+      console.log(customMarkdownLintConfig, lintConfigJson)
     } catch (err) {
-      throw err
+      eventEmitter.emit('APP_SETTING_ERROR')
+      return
     }
     const lintOptions = {
       'strings': {

diff --git a/browser/components/MarkdownEditor.js b/browser/components/MarkdownEditor.js
@@ -194,7 +194,6 @@ class MarkdownEditor extends React.Component {
   }
 
   reload () {
-    console.log('reloading editor...')
     this.refs.code.reload()
     this.cancelQueue()
     this.renderPreview(this.props.value)
@@ -278,7 +277,7 @@ class MarkdownEditor extends React.Component {
     if (this.props.ignorePreviewPointerEvents) previewStyle.pointerEvents = 'none'
 
     const storage = findStorage(storageKey)
-    console.log('render editor', config)
+
     return (
       <div className={className == null
           ? 'MarkdownEditor'

diff --git a/browser/main/modals/PreferencesModal/UiTab.js b/browser/main/modals/PreferencesModal/UiTab.js
@@ -40,6 +40,7 @@ class UiTab extends React.Component {
       }})
     }
     this.handleSettingError = (err) => {
+      console.log('handle err', err)
       this.setState({UiAlert: {
         type: 'error',
         message: err.message != null ? err.message : i18n.__('An error occurred!')