-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenSearch support #5198
Add OpenSearch support #5198
Conversation
Thanks for offering this @maximilian-walter! Here's my feedback from a quick review (have not actually pulled down and tested yet):
Are you happy to take on these changes? Just let me know if you need further help/guidance, or if you're not able to perform further work for any reason. |
The specification does not allow more than 16 characters.
Thanks @ssddanbrown for your feedback!
I don't know if higher resolutions would be used. I would expect that, but I did not validate it. Because we have them already I would keep them, but I am also fine if you wish to reduce the number of links.
You are right, I removed the attribute. We don't need it anyway.
The hardlimit of 16 characters is now enforced.
I moved the description to the language file. I hope this was the correct way of doing it in regards of Crowdin.
I added some basic test based on your HtmlTest-class. Because the Symfony Crawler is used, I assumed it is fine to feed XML to it. :) A proper XML schema validation would be much better, but I did not find any DTD file for this standard. |
Thanks @maximilian-walter! Could you just also restore the two |
fde4962
to
2f74cfb
Compare
@ssddanbrown Sorry, I added the missing files again and rebased my branch so the files do not get removed and added again. Squashing is still a good idea. I used multiple small commits only for a easier code review. :) |
Now merged for next feature release, thanks again @maximilian-walter! While testing I found that chrome would totally ignore opensearch discovery if not hosting on the root of the domain, whereas Firefox was totally happy with that. Will have to remember this for future potential support scenarios! |
Add XML-file and HTML meta-tag so browsers can autodiscover the search of BookStack instances. See:
https://developer.mozilla.org/en-US/docs/Web/OpenSearch
Closes #5122