Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15KB lossless optimization via oxipng(PNG) and svgo(SVG) #4904

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

C0rn3j
Copy link
Contributor

@C0rn3j C0rn3j commented Mar 16, 2024

It is not much, but it is not nothing.

@ssddanbrown
Copy link
Member

Thanks for this @C0rn3j.
Before I merge, please could you remove any changes from the tests/ directory?
Also, please could you share the commands/options/configurations/script used for the conversions made? Would be good to have that as a reference for how this optimization was done, and should be useful to have on-hand for future changes.

@C0rn3j
Copy link
Contributor Author

C0rn3j commented Mar 19, 2024

Before I merge, please could you remove any changes from the tests/ directory?

Sure thing, will do so when I find a bit of time

Also, please could you share the commands/options/configurations/script used for the conversions made?

See https://invent.kde.org/plasma/plasma-workspace-wallpapers/-/merge_requests/17#note_895818 https://rys.rs/optimization

@C0rn3j
Copy link
Contributor Author

C0rn3j commented Mar 23, 2024

Took out the test dir

@C0rn3j
Copy link
Contributor Author

C0rn3j commented Mar 26, 2024

Found out GIFs can also be losslessly optimized, so another 2KB down on the loading animation, plus 0.6KB on the existing PNG optims due to additional --zopfli flag.

@ssddanbrown
Copy link
Member

Thanks @C0rn3j, looks good! Will merge for next feature release.

@ssddanbrown ssddanbrown merged commit d9ff001 into BookStackApp:development Apr 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants