Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified mail notifications to add the name of the book #4629

Closed

Conversation

Man-in-Black
Copy link
Contributor

As written on discord I've changed the mail notifications to add the title of the book.
It's my first real pull request, so I hope I've done everything right ;)
This time with the right codebase ;)

@Man-in-Black
Copy link
Contributor Author

I've just got the idea to extend the whole notification, so as fpr now it is showing the book name as well as the chapter name if present.

without chapter:
image

with chapter:
image

@ssddanbrown ssddanbrown added this to the Next Feature Release milestone Oct 30, 2023
ssddanbrown added a commit that referenced this pull request Nov 14, 2023
- Merged book and chapter name items to a single page path list item
  which has links to parent page/chapter.
- Added permission filtering to page path elements.
- Added page path to also be on comment notifications.
- Updated testing to cover.
- Added new Message Line objects to support.

Done during review of #4629
@ssddanbrown
Copy link
Member

Thanks again for this @Man-in-Black.
I've now merged this in via commit 65ac197 (I squashed your changes down to a single commit to clean up the history of changes).

I followed this up with d41fd7a, which added testing and tweaked the format a bit so that both the parent chapter and book are instead shown as a "Page Path:" item in the details list, with the names linked to the item in BookStack. This is to keep the details focused on pages being the main context of the email.
The changes in this commit also add testing, permission control and add these details also to the comment notification.

This will be part of the next feature release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants