-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified mail notifications to add the name of the book #4629
Modified mail notifications to add the name of the book #4629
Conversation
- Merged book and chapter name items to a single page path list item which has links to parent page/chapter. - Added permission filtering to page path elements. - Added page path to also be on comment notifications. - Updated testing to cover. - Added new Message Line objects to support. Done during review of #4629
Thanks again for this @Man-in-Black. I followed this up with d41fd7a, which added testing and tweaked the format a bit so that both the parent chapter and book are instead shown as a "Page Path:" item in the details list, with the names linked to the item in BookStack. This is to keep the details focused on pages being the main context of the email. This will be part of the next feature release. |
As written on discord I've changed the mail notifications to add the title of the book.
It's my first real pull request, so I hope I've done everything right ;)
This time with the right codebase ;)