Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing type specifications for name and password in /users CREATE endpoint documentation #5183

Closed
ln-ws opened this issue Aug 27, 2024 · 1 comment

Comments

@ln-ws
Copy link

ln-ws commented Aug 27, 2024

Describe the Bug

In the BookStack API documentation for the /users endpoint, specifically for the CREATE request, the body parameters documentation fails to specify the required type for the name and password properties. This omission can lead to confusion for developers implementing API calls, potentially resulting in incorrect data types being sent and causing unexpected errors.

Steps to Reproduce

  1. Navigate to the BookStack API documentation.
  2. Scroll down to the section for the /users endpoint.
  3. Find the documentation for the CREATE request.
  4. Observe that the name property lacks a type specification.
  5. Observe that the password property also lacks a type specification.
  6. Compare these to other properties in the same documentation that do have type specifications.

Expected Behaviour

We expect the body parameters documentation for the /users CREATE endpoint to clearly specify the data types for all properties. Specifically:

  • The name property should be explicitly labeled with the type string.
  • The password property should also be explicitly labeled with the type string.
  • This type information should be consistently presented, matching the format used for other properties in the same documentation.

Screenshots or Additional Context

No response

Browser Details

No response

Exact BookStack Version

v24.05.3

@ssddanbrown
Copy link
Member

Thanks for raising @ln-ws, this has been addressed as part of 1f25062 to be part of the next patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants