-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: detect the missing of rabbitmq queue and redeclare it. #556
Conversation
Hi, @Bogdanp , do you have time to review this fix? Many thanks for your work! |
06d6f17
to
9212eb9
Compare
Hi, @Bogdanp , do you have time to review this fix? I've update a newer version. We have run Dramatiq with this fix for a while at our production environment and it's necessary for long-running rabbitmq workers to include this fix to ensure reliability. Thanks for your time. |
Hi @JetDrag, I'll try to review this PR sometime around the end of next week. |
@Bogdanp roger, thanks |
9212eb9
to
153fd42
Compare
Hi, @Bogdanp , I've resolve the conversation you added before, please review again. |
153fd42
to
7141d40
Compare
Hi, @Bogdanp , I've resolve the conversation you added before, when will you have time to review the renewed fix? We have run Dramatiq with this fix for a while at our production environment and it's necessary for long-running rabbitmq workers to include this fix to ensure reliability. Many thanks! |
d215645
to
ca25386
Compare
Hi, @Bogdanp , I've resolve the failure of lint, make sure the test cases in workflow is passed in my forked project. Could you approve the workflow in this PR? |
I see both my comments were marked as resolved, but they don't seem to be addressed? |
3dc8fc7
to
b586e5d
Compare
Sorry, there's something missing during rebase. I've updated the code to make sure your comments are resolved. And I also add some enhancements to make sure the concurrent running tests will passed. Please approve the workflow and review again. @Bogdanp |
The suggestion in https://github.com/Bogdanp/dramatiq/pull/556/files#r1334929506 still doesn't seem to be addressed. The idea is to avoid adding a |
073e824
to
a7f2cef
Compare
Sorry for the omission, it seem there're some bugs in the online github CodeSpace. I've refined and pushed it again. Thank you for your patience and work. |
d151075
to
91c68d5
Compare
7391a36
to
6b2311d
Compare
6b2311d
to
2055546
Compare
Awesome work! Thanks to your patient and meticulous! |
The declared rabbitmq queue will be missing sometime, such as deletion by mistake or rabbitmq server failure. So I add some logic to make sure the missing queue to be declared again, as the recent implementation won't auto re-declare the missing queue.
There are two situation to re-declare the missing queue: