Add more options to django command wrapper #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bogdanp
reviewed
Aug 29, 2018
| "--threads", str(threads) | ||
| ] | ||
|
|
||
| if queues: |
There was a problem hiding this comment.
This flag should be appended at the very end of the argument list, otherwise it's ambiguous in conjunction with the MODULE_NAME positional arg:
dramatiq --threads 8 --proceses 8 --queues a b c d module_a module_b
has a different meaning from
dramatiq --threads 8 --proceses 8 module_a module_b --queues a b c d
Bogdanp
requested changes
Aug 29, 2018
|
gotcha 👌 I made the requested changes! no rush and relax 🌴 |
MattBlack85
changed the title
|
Thanks again! This is merged in 9ce6107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to make the django command wrapper more similar to the original one allowing to pass more arguments:
--queues--log-file,--pid-file