Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readimc to 0.7.0 + lenient parsing option #262

Merged
merged 6 commits into from
May 28, 2024

Conversation

matt-sd-watson
Copy link
Contributor

@matt-sd-watson matt-sd-watson commented May 14, 2024

Summary of proposed changes

Copy link
Contributor

@Milad4849 Milad4849 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for your contribution!

@matt-sd-watson
Copy link
Contributor Author

Looks like the build may be suffering from the napari dependency error here

@Milad4849
Copy link
Contributor

Hi @matt-sd-watson,
Yes indeed that is the issue. They have not pushed a fix for it yet. I am trying to figure out if adding lxml_html_clean explicitly to the requirements would fix this.

fcswrite==0.6.2
h5py==3.8.0
imageio==2.25.0
napari[all]==0.4.17
napari[all]==0.4.19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

napari[all]==0.4.19
lxml_html_clean==0.1.1

@Milad4849 Milad4849 merged commit c21376a into BodenmillerGroup:main May 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update readimc to 0.7.0 for lenient parsing
2 participants