Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concatenated anndata export does not retain neighborhood information #196

Open
jwindhager opened this issue Jun 16, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@jwindhager
Copy link
Contributor

As reported by @cavenel, when running steinbock export anndata in concatenation mode (default) and with --neighbors, the resulting multi-image anndata object does not contain the spatial cell graphs in obsp. This is because anndata.concat does not concatenate obsp by default, see here:

Note that we concatenated along the observations by default, and that most elements aligned to the observations were concatenated as well. A notable exception is obsp, which can be re-enabled with the pairwise keyword argument. This is because it’s not obvious that combining graphs or distance matrices padded with 0s is particularly useful, and may be unintuitive.

It would be good either to enable obsp concatenation (see quote above), or to not allow the --neighbors argument in concatenation mode (i.e., print an error message).

@jwindhager jwindhager added the bug Something isn't working label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant