Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mcd_file.py #32

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Update mcd_file.py #32

merged 2 commits into from
Sep 9, 2024

Conversation

sandip-shah
Copy link
Contributor

The before and after ablation images are PNGs, and usually one will not want to do any processing on this data.

The current functionality retrieves this data as a numpy array, due to which the properties attached to the png file are lost (e.g. timestamp when it was created).

The code has been modified to maintain the normal behavior, but if the "raw" boolean flag is specified during the request of these files, then the raw png data is returned (as opposed to the numpy array).

One can easily save this data to a png file, and retain all the metadata associated with the png file.

sandip-shah and others added 2 commits September 4, 2024 17:10
The before and after ablation images are PNGs, and usually one will not want to do any processing on this data.

The current functionality retrieves this data as a numpy array, due to which the properties attached to the png file are lost (e.g. timestamp when it was created).

The code has been modified to maintain the normal behavior, but if the "raw" boolean flag is specified during the request of these files, then the raw png data is returned (as opposed to the numpy array).

One can easily save this data to a png file, and retain all the metadata associated with the png file.
@Milad4849
Copy link
Contributor

Milad4849 commented Sep 6, 2024

Hi @sandip-shah
Could you please update the CHANGELOG.md with your changes please? This would be the v0.8 release, thanks.

@Milad4849 Milad4849 merged commit 19a5794 into BodenmillerGroup:main Sep 9, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants