Skip to content
This repository has been archived by the owner on Mar 31, 2022. It is now read-only.

Commit

Permalink
Prevent crash on corrupted MCD acquisitions in order to keep valid ones.
Browse files Browse the repository at this point in the history
  • Loading branch information
plankter committed Jan 21, 2021
1 parent 9e028e1 commit 18779e1
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 12 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [2.1.2] - 2021-01-21
- Prevent crash on corrupted MCD acquisitions in order to keep valid ones

## [2.1.1] - 2021-01-20
- Update `xtiff` package
- FIX: Wrong ROI coordinates for new Fluidigm software versions #104
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Version 1.x documentation (deprecated): https://imctools.readthedocs.io

Preferable way to install `imctools` is via official PyPI registry. Please define package version explicitly in order to avoid incompatibilities between v1.x and v2.x versions:
```
pip install imctools==2.1.1
pip install imctools==2.1.2
```
In old IMC segmentation pipelines versions 1.x should be used!
```
Expand Down
2 changes: 1 addition & 1 deletion docs/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ <h2 id="prerequisites">Prerequisites</h2>
</ul>
<h2 id="installation">Installation</h2>
<p>Preferable way to install <code><a title="imctools" href="#imctools">imctools</a></code> is via official PyPI registry. Please define package version explicitly in order to avoid incompatibilities between v1.x and v2.x versions:</p>
<pre><code>pip install imctools==2.1.1
<pre><code>pip install imctools==2.1.2
</code></pre>
<p>In old IMC segmentation pipelines versions 1.x should be used!</p>
<pre><code>pip install imctools==1.0.8
Expand Down
12 changes: 6 additions & 6 deletions docs/io/mcd/mcdparser.html
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,11 @@ <h1 class="title">Module <code>imctools.io.mcd.mcdparser</code></h1>
if acquisition is None:
return None
data = self._get_acquisition_raw_data(acquisition)
if data is not None:
try:
image_data = reshape_long_2_cyx(data, is_sorted=True)
# Drop first three channels X, Y, Z
image_data = image_data[3:]
else:
except:
image_data = None
acquisition.is_valid = False
logger.warning(f&#34;Error reading MCD acquisition: {acquisition_id}&#34;)
Expand Down Expand Up @@ -393,11 +393,11 @@ <h2 class="section-title" id="header-classes">Classes</h2>
if acquisition is None:
return None
data = self._get_acquisition_raw_data(acquisition)
if data is not None:
try:
image_data = reshape_long_2_cyx(data, is_sorted=True)
# Drop first three channels X, Y, Z
image_data = image_data[3:]
else:
except:
image_data = None
acquisition.is_valid = False
logger.warning(f&#34;Error reading MCD acquisition: {acquisition_id}&#34;)
Expand Down Expand Up @@ -693,11 +693,11 @@ <h3>Methods</h3>
if acquisition is None:
return None
data = self._get_acquisition_raw_data(acquisition)
if data is not None:
try:
image_data = reshape_long_2_cyx(data, is_sorted=True)
# Drop first three channels X, Y, Z
image_data = image_data[3:]
else:
except:
image_data = None
acquisition.is_valid = False
logger.warning(f&#34;Error reading MCD acquisition: {acquisition_id}&#34;)
Expand Down
4 changes: 2 additions & 2 deletions imctools/io/mcd/mcdparser.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,11 @@ def get_acquisition_data(self, acquisition_id: int):
if acquisition is None:
return None
data = self._get_acquisition_raw_data(acquisition)
if data is not None:
try:
image_data = reshape_long_2_cyx(data, is_sorted=True)
# Drop first three channels X, Y, Z
image_data = image_data[3:]
else:
except:
image_data = None
acquisition.is_valid = False
logger.warning(f"Error reading MCD acquisition: {acquisition_id}")
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"

[tool.poetry]
name = "imctools"
version = "2.1.1"
version = "2.1.2"
description = "Tools to handle Fluidigm IMC data"
license = "MIT"
authors = ["Vito Zanotelli <[email protected]>", "Anton Rau <[email protected]>"]
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 2.1.1
current_version = 2.1.2
commit = False
tag = False

Expand Down

0 comments on commit 18779e1

Please sign in to comment.