replace minDistToCells by distToCells #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, would also be good to add this to NEWS and issue a version bump. |
|
@nilseling thats my job now ;) |
lassedochreden
requested changes
Jun 25, 2024
There was a problem hiding this comment.
Hi @brunopalau, great job! See my comments - Also as @nilseling suggested above, please update the NEWS and perform a version bump (to 1.11.1 I think - will double-check)
| @@ -0,0 +1,595 @@ | |||
| test_that("distToCells works",{ | |||
There was a problem hiding this comment.
I think here you just copied the tests four times depending on the metric, which is okay but not totally necessary. Would be good to have some tests that numerically test the differences between all the metrics for a given image.
| expect_true(class(cur_sce$distToCells) == "numeric") | ||
| expect_true(min(cur_sce$distToCells) < 0) | ||
| expect_true(sum(cur_sce$distToCells < 0) == sum(pancreasSCE$CellType == "celltype_B")) | ||
| # TODO: for all cases, enforces that a cells not of interest and a cell of interect do not have the same exact coordinates |
There was a problem hiding this comment.
is this a new TODO?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced minDistToCells function by superior distToCells function, which contains minDistToCells but also allows the user to specify the "metric" parameter and therefore compute min, max, mean and median distances to cells of interest, while exactly mimicking the minDistToCells output when using metric="min"