feat: add cython extension for signature #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 81.21% // Head: 81.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
+ Coverage 81.21% 81.49% +0.27%
==========================================
Files 25 25
Lines 2928 2923 -5
Branches 569 567 -2
==========================================
+ Hits 2378 2382 +4
+ Misses 339 332 -7
+ Partials 211 209 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bdraco
changed the title
bdraco
changed the title
bdraco
commented
Oct 4, 2022
|
Additional significant improvements would require getting rid of the dict dispatch so we can make the read functions cdef instead of cpdef. That trade off may not be worth it though since it would make the pure python code paths slower. |
bdraco
commented
Oct 4, 2022
| @@ -255,13 +255,6 @@ def new_signal( | |||
| unix_fds=unix_fds, | |||
| ) | |||
|
|
|||
| def _matches(self, **kwargs): | |||
| for attr, val in kwargs.items(): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is roughly at 10% improvement to the unmarshall path